Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch lifecycle to avoid interacting with project boards overly #375

Merged
merged 14 commits into from
Sep 12, 2024

Conversation

lilyminium
Copy link
Contributor

@lilyminium lilyminium commented Sep 10, 2024

This PR patches lifecycle.py to give up on moving things between board columns and just submit the datasets. It's meant to be a temporary, easier to review fix than #377.

@lilyminium lilyminium added the test-label This is a test label to be added or removed automatically via CI. label Sep 11, 2024
@lilyminium lilyminium mentioned this pull request Sep 11, 2024
@lilyminium lilyminium added tracking test-label This is a test label to be added or removed automatically via CI. test-ci and removed test-label This is a test label to be added or removed automatically via CI. test-ci labels Sep 11, 2024
@openff-dangerbot openff-dangerbot added test-label This is a test label to be added or removed automatically via CI. and removed test-label This is a test label to be added or removed automatically via CI. labels Sep 11, 2024
@openff-dangerbot
Copy link
Contributor

This is a test comment from running CI. Please ignore

@openff-dangerbot openff-dangerbot added test-label This is a test label to be added or removed automatically via CI. and removed test-label This is a test label to be added or removed automatically via CI. labels Sep 11, 2024
@openff-dangerbot
Copy link
Contributor

This is a test comment from running CI. Please ignore

@openff-dangerbot openff-dangerbot added test-label This is a test label to be added or removed automatically via CI. and removed test-label This is a test label to be added or removed automatically via CI. labels Sep 11, 2024
@openff-dangerbot
Copy link
Contributor

This is a test comment from running CI. Please ignore

@lilyminium
Copy link
Contributor Author

lilyminium commented Sep 11, 2024

Apologies for the messy dangerbot actions -- I refactored lifecycle.py to use GraphQL, but then split that out into a separate PR #377. This is now just a bandaid patch to try to get datasets submitted before #377 can get merged. We will have to manually move the card to the Error cycling to get that to trigger, I believe.

@lilyminium
Copy link
Contributor Author

@lilyminium lilyminium changed the title Update token in lifecycle submission Patch lifecycle to avoid interacting with project boards overly Sep 11, 2024
@lilyminium
Copy link
Contributor Author

I think this is now ready for review.

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for updating this and apologies that this held up submissions!

@lilyminium
Copy link
Contributor Author

Thanks for the review @j-wags!

@lilyminium lilyminium merged commit 62a8290 into master Sep 12, 2024
@lilyminium lilyminium deleted the update-tokens-in-ci branch September 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants